⬆️ Bump Typer to 0.20.0 to add command suggestions on typo#229
⬆️ Bump Typer to 0.20.0 to add command suggestions on typo#229savannahostrowski wants to merge 1 commit intofastapi:mainfrom
Conversation
There was a problem hiding this comment.
I think the suggestions in 0.20.0 are great, but do we have to bump here? I'd personally only bump the lower-bound for compatibility reasons. Here, I assume that any new install will simply get Typer 0.20.0 even if we don't bump, so why do we need to enforce it (genuine question)? I just want to be mindful of those users/use-cases that want to stick to an older version of Typer for some reason...
|
Good question! My rationale here was that From a UX perspective, I'd also argue that suggestions on typos are commonplace in modern CLIs, so it'd be nice if we could ensure a consistent UX for all users. It'd be weird to have the CLI only provide suggestions if the user's deps happened to transitively resolve to 0.20.0, right? By bumping the lower bound, we guarantee everyone gets the same base experience. |
|
I see where you're coming from, I'm just unsure whether we need to make that decision for users or not. They might have a pin on Typer in the same |
|
Thank you! Commenting here just to reflect the internal discussion. 😅 Let's not bump here, most users will get the upgraded version, but if one of them has an app that has an upper bound pin, if we require this lowerbound, the package manager will just install an older version of ...at some point, we might end up adding a feature in Typer that we need here and we'll end up having the new lower bound pin anyway, but if we can skip it for now, let's do that. 🤓 |
With https://github.com/fastapi/typer/releases/tag/0.20.0, Typer now provides command suggestions on error, meaning we get this UX for free.